Hacker News

...

status_quo69

149

Karma

2016-11-29

Created

Recent Activity

  • Commented: "The Theatre of Pull Requests and Code Review"

    You can and should break that up because I'm probably going to want to see screenshots to ensure that the branding changes make sense in context and everything looks consistent.

    How would you do this? You'd either

    1. Create N pull requests then merge all of them together into a big PR that would get merged into mainline at once 2. Do the same thing but do a bit of octopus merging since git merge can take multiple branches as arguments. Since most source control strategies are locked down, this isn't usually something that I can tell my juniors to do

    The point of breaking things down like this is to minimize reviewer context. With bigger PRs there's a human tendency to try and hold the whole thing in your head at once, even if parts of the pull request are independent from others.

  • Commented: "Past, present, and future of Sorbet type syntax"

    One thing that I've wondered is why sorbet didn't choose to use the stabby lambda syntax to denote function signatures?

      sig ->(_: MyData) { }
  def self.example(my_data)
    ...
  end
    Obviously this opens up a potential can of worms of a dynamic static type system, but it looks sufficiently close enough to just ruby. My opinion is that sorbet doesn't lean into the weirdness of ruby enough, so while it has the potential to be an amazingly productive tool, this is the same community that (mostly) embraces multiple ways of doing things for aesthetic purposes. For example you could get the default values of the lambda above to determine the types of the args by calling the lambda with dummy values and capturing via binding.

    Personally having written ruby/rails/c#/etc and having been on a dev productivity team myself, I say: lean into the weird shit and make a dsl for this since that's what it wants to be anyways. People will always complain, especially with ruby/rails.

  • Commented: "Statewide fluoride ban for tap water passes in Florida"

    https://pmc.ncbi.nlm.nih.gov/articles/PMC2925001/

    Not everyone has impeccable brushing habits and reducing cavities is a net benefit to public health like sanitation departments. I would be more interested to see a source as to why you think there's no benefit to fluorinated water when there are studies that are a quick search away for fluorinated water.

  • Commented: "DOGE puts $1 spending limit on government employee credit cards"

    Not sure why you're being confrontational? I'm not the OP but it's clear there's some misunderstanding

    The quote is: - neat - plausible - wrong

    "Just get rid of the cancer" is - neat because it sounds obvious and tidy - plausible because we can and do cut out cancer - wrong because it ignores the nuance that cutting into a patient's body can have massive impacts on long term health. It can also be wrong because certain cancers have no tumor sites.

  • Commented: "Types are a basic tool of software design (2018)"

    [dead]

HackerNews

About